Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)

src/test/unittest/basetest.py line 171 at r1 (raw file):

        """
        self.ctx = c
        start_time = None

Why?

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @osalyk)

src/test/unittest/basetest.py line 171 at r1 (raw file):

Otherwise, if any of the clean() or setup() steps fail before the start_time is assigned for the first time you will end up with an error followed by an error.

futils.Fail: xxx

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "./RUNTESTS.py", line 220, in <module>
    main()
  File "./RUNTESTS.py", line 216, in main
    sys.exit(runner.run_tests())
  File "./RUNTESTS.py", line 119, in run_tests
    t._execute(c)
  File "/home/jmichal/work/pmdk/src/test/unittest/basetest.py", line 190, in _execute
    if start_time is not None:
UnboundLocalError: local variable 'start_time' referenced before assignment

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)

src/test/unittest/basetest.py line 171 at r1 (raw file):

Maybe leave a trace of it as a comment in the code.

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @osalyk)

src/test/unittest/basetest.py line 171 at r1 (raw file):

Done.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)